Re: [PATCH] staging: greybus: match parenthesis alignment
From: Greg Kroah-Hartman
Date: Wed Feb 19 2020 - 15:19:20 EST
On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:
> Fix checkpatch.pl warning of alignment should match open parenthesis in
> audio_codec.c
>
> Signed-off-by: Kaaira Gupta <kgupta@xxxxxxxxxxxxx>
> ---
> drivers/staging/greybus/audio_codec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 08746c85dea6..d62f91f4e9a2 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_register_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_TX);
You can't do it for one line, and not all of the lines.
And if you do it for all lines, then you push past the line-length.
So you are back to what we currently have, which is the best we can do,
sorry.
greg k-h