Re: [PATCH 3/4] dt-bindings: mfd: motmdm: Add binding for motorola-mdm

From: Rob Herring
Date: Wed Feb 19 2020 - 17:13:15 EST


On Sun, Feb 09, 2020 at 08:01:05PM -0800, Tony Lindgren wrote:
> Add a binding document for Motorola modems controllable by
> TS 27.010 UART line discipline using serdev drivers.
>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> .../mfd/motorola,mapphone-mdm6600.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/motorola,mapphone-mdm6600.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/motorola,mapphone-mdm6600.yaml b/Documentation/devicetree/bindings/mfd/motorola,mapphone-mdm6600.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/motorola,mapphone-mdm6600.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/motorola,mapphone-mdm6600.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Motorola Mapphone MDM6600 Modem
> +
> +maintainers:
> + - Tony Lindgren <tony@xxxxxxxxxxx>
> +
> +allOf:
> + - $ref: "motorola,mapphone-mdm6600.yaml#"

Huh? A recursive include? I'm not sure how that didn't blow up.

> +
> +properties:
> + compatible:
> + items:
> + - const: motorola,mapphone-mdm6600-serial
> +
> + phys:
> + maxItems: 1
> +
> + phy-names:
> + const: usb
> +
> +required:
> + - compatible
> + - phys
> + - phy-names
> +
> +examples:
> + - |
> + modem {
> + compatible = "motorola,mapphone-mdm6600-serial";
> + phys = <&fsusb1_phy>;
> + phy-names = "usb";
> + };
> --
> 2.25.0