Re: [PATCH v5 4/8] drivers: thermal: tsens: Release device in success path

From: Stephen Boyd
Date: Wed Feb 19 2020 - 17:55:53 EST


Quoting Amit Kucheria (2020-02-18 10:12:08)
> We don't currently call put_device in case of successfully initialising
> the device.

Sure, but why is that a problem? Presumably the device is kept pinned
forever?

>
> Allow control to fall through so we can use same code for success and
> error paths to put_device.
>
> As a part of this fixup, change devm_ioremap_resource to act on the same
> device pointer as that used to allocate regmap memory. That ensures that
> we are free to release op->dev after examining its resources.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>