Re: [PATCH 1/9] dt-bindings: remoteproc: Convert imx-rproc to json-schema

From: Rob Herring
Date: Wed Feb 19 2020 - 19:38:01 EST


On Wed, Feb 19, 2020 at 8:34 AM Peng Fan <peng.fan@xxxxxxx> wrote:
>
> Hi Rob,
>
> > Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: Convert imx-rproc to
> > json-schema
> >
> > On Wed, 19 Feb 2020 15:27:37 +0800, peng.fan@xxxxxxx wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Convert the i.MX remoteproc binding to DT schema format using
> > > json-schema
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > > .../devicetree/bindings/remoteproc/imx-rproc.txt | 33 ------------
> > > .../devicetree/bindings/remoteproc/imx-rproc.yaml | 61
> > > ++++++++++++++++++++++
> > > 2 files changed, 61 insertions(+), 33 deletions(-) delete mode
> > > 100644 Documentation/devicetree/bindings/remoteproc/imx-rproc.txt
> > > create mode 100644
> > > Documentation/devicetree/bindings/remoteproc/imx-rproc.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
>
> My command:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/imx-rproc.yaml
>
> and output:
>
> CHKDT Documentation/devicetree/bindings/remoteproc/imx-rproc.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
> DTC Documentation/devicetree/bindings/remoteproc/imx-rproc.example.dt.yaml
> CHECK Documentation/devicetree/bindings/remoteproc/imx-rproc.example.dt.yaml

Make sure dtschema is up to date though I'm not sure this could have
ever passed. 'items' value is clearly wrong.

Rob