Re: [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver
From: Jon Hunter
Date: Thu Feb 20 2020 - 10:16:56 EST
On 20/02/2020 06:34, Sameer Pujar wrote:
> ADMAIF is the interface between ADMA and AHUB. Each ADMA channel that
> sends/receives data to/from AHUB must intreface through an ADMAIF channel.
> ADMA channel sending data to AHUB pairs with an ADMAIF Tx channel and
> similarly ADMA channel receiving data from AHUB pairs with an ADMAIF Rx
> channel. Buffer size is configuranle for each ADMAIF channel, but currently
> SW uses default values.
> This patch registers ADMAIF driver with ASoC framework. The component
> driver exposes DAPM widgets, routes and kcontrols for the device. The DAI
> driver exposes ADMAIF interfaces, which can be used to connect different
> components in the ASoC layer. Makefile and Kconfig support is added to
> allow to build the driver. The ADMAIF device can be enabled in the DT via
> "nvidia,tegra210-admaif" compatible binding.
> Tegra PCM driver is updated to expose required PCM interfaces and
> snd_pcm_ops callbacks.
> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> sound/soc/tegra/Kconfig | 12 +
> sound/soc/tegra/Makefile | 2 +
> sound/soc/tegra/tegra210_admaif.c | 884 ++++++++++++++++++++++++++++++++++++++
> sound/soc/tegra/tegra210_admaif.h | 164 +++++++
> sound/soc/tegra/tegra_pcm.c | 222 +++++++++-
> sound/soc/tegra/tegra_pcm.h | 23 +-
> 6 files changed, 1305 insertions(+), 2 deletions(-)
> create mode 100644 sound/soc/tegra/tegra210_admaif.c
> create mode 100644 sound/soc/tegra/tegra210_admaif.h
Aside from Randy's comment ...
Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>