Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

[Dr. David Alan Gilbert]

* Guenter Roeck (linux@xxxxxxxxxxxx) wrote:
> On 2/20/20 5:57 AM, Dr. David Alan Gilbert wrote:
> > * Meelis Roos (mroos@xxxxxxxx) wrote:
> > > > It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
> > > > which has:
> > > > 
> > > >                   if (attr == hwmon_temp_input || attr == hwmon_temp_label)
> > > >                           return 0444;
> > > > 
> > > > to
> > > >                   if (attr == hwmon_temp_input)
> > > >                           return 0444;
> > > >                   if (attr == hwmon_temp_label) {
> > > >                           if (data->temp_label)
> > > > 				return 0444;
> > > > 			else
> > > > 				return 0;
> 
> Nitpick: else after return isn't necessary. Too bad I didn't notice that before;
> static analyzers will have a field day :-)
> 
> > > >                   }
> > > > 
> > > > Does that work for you?
> > > Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
> > > 
> > > Thank you for so quick response!
> > 
> > Great, I need to turn that into a proper patch; (I might need to wait till
> > Saturday for that, although if someone needs it before then please shout).
> > 
> 
> We'll want this fixed in the next stable release candidate, so I wrote one up
> and submitted it.

Thanks!

Dave

> Thanks,
> Guenter
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/