Re: [PATCH 30/32] pwm: hibvt: do some cleanup
From: Uwe Kleine-König
Date: Thu Feb 20 2020 - 15:42:36 EST
On Sun, Dec 29, 2019 at 08:06:08AM +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 'i' and 'ret' are variables of the same type and there is no
> need to use two lines.
I think I wouldn't have merged these two lines, but I don't feel strong
here. The other 31 patches are clean replacements.
But I also don't think respining just for this minor thing is worth the
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
for the whole series. (Not sure it is sensible to ack each patch
individually, @Thierry, tell me if this simplifies things for you.)
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |