Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver

[Randy Dunlap]

On 2/20/20 4:06 PM, Scott Branden wrote:
> Hi Randy,
> 
> On 2020-02-19 5:04 p.m., Randy Dunlap wrote:
>> Hi,
>>
>> On 2/19/20 4:48 PM, Scott Branden wrote:
>>> diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig
>>> new file mode 100644
>>> index 000000000000..c75dfb89a38d
>>> --- /dev/null
>>> +++ b/drivers/misc/bcm-vk/Kconfig
>>> @@ -0,0 +1,42 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +#
>>> +# Broadcom VK device
>>> +#
>>> +config BCM_VK
>>> +ÂÂÂ tristate "Support for Broadcom VK Accelerators"
>>> +ÂÂÂ depends on PCI_MSI
>>> +ÂÂÂ default m
>> Need to justify default m. Normally we don't add drivers as enabled unless
>> they are required for basic (boot) operation.
> Will remove default m as not needed to boot. Interesting other offload engines misc/ocxl/Kconfig and misc/cxl/Kconfig have default m.

Thanks.

Uh, yes, that is interesting.  They both depend on PPC_POWERNV,
which I know nothing about.

>>> +ÂÂÂ help
>>> +ÂÂÂÂÂ Select this option to enable support for Broadcom
>>> + VK Accelerators. VK is used for performing
>>> + specific video offload processing. This driver enables
>>> +ÂÂÂÂÂ userspace programs to access these accelerators via /dev/bcm-vk.N
>>> +ÂÂÂÂÂ devices.
>>> +
>>> +ÂÂÂÂÂ If unsure, say N.

-- 
~Randy