Re: [PATCH 0/5] Enable pt_regs based syscalls for x86-32 native

From: Dominik Brodowski
Date: Fri Feb 21 2020 - 02:07:41 EST


Brian,

On Fri, Feb 21, 2020 at 12:09:29AM -0500, Brian Gerst wrote:
> This patch series cleans up the x86 syscall wrapper code and converts
> the 32-bit native kernel over to pt_regs based syscalls.

thanks for your patchset. Could you explain a bit more what the rationale
is. Due to asmlinkage, it doesn't leak "random user-provided register
content down the call chain" (as was the case for x86-64). But it may be
cleaner, and you mention in patch 5/5 that the new way is "a bit more
efficient" -- do you have numbers?

Thanks,
Dominik