Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average
From: Dietmar Eggemann
Date: Fri Feb 21 2020 - 04:58:04 EST
On 14/02/2020 16:27, Vincent Guittot wrote:
[...]
fdef CONFIG_SMP
> @@ -2940,15 +2913,12 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
> u32 divider = LOAD_AVG_MAX - 1024 + se->avg.period_contrib;
>
> se->avg.load_avg = div_u64(se_weight(se) * se->avg.load_sum, divider);
> - se->avg.runnable_load_avg =
> - div_u64(se_runnable(se) * se->avg.runnable_load_sum, divider);
> } while (0);
> #endif
>
> enqueue_load_avg(cfs_rq, se);
> if (se->on_rq) {
> account_entity_enqueue(cfs_rq, se);
> - enqueue_runnable_load_avg(cfs_rq, se);
> }
Nit pick: No curly brackets needed anymore.
[...]