Re: [PATCH 13/19] vfs: Add a mount-notification facility [ver #16]

[David Howells]

Jann Horn <jannh@xxxxxxxxxx> wrote:

> > + * Post mount notifications to all watches going rootwards along the tree.
> > + *
> > + * Must be called with the mount_lock held.
> 
> Please put such constraints into lockdep assertions instead of
> comments; that way, violations can actually be detected.

What's the best way to write a lockdep assertion?

	BUG_ON(!lockdep_is_held(lock));

David