Re: [PATCH v2] dt-bindings: iio: adc: ad7923: Add binding documentation for AD7928

[Jonathan Cameron]

On Tue, 18 Feb 2020 08:06:47 -0300
Daniel Junho <djunho@xxxxxxxxx> wrote:

> From: Daniel Junho <djunho@xxxxxxxxx>
> 
> This patch add device tree binding documentation for AD7923 adc in YAML
> format.
> 
> Signed-off-by: Daniel Junho <djunho@xxxxxxxxx>

One thing inline. I'll fix up when applying.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
> Changes in v2:
> - Fix the license header to "GPL-2.0-only OR BSD-2-Clause";
> - Change the Michael Hennerich email.
> 
>  .../bindings/iio/adc/adi,ad7923.yaml          | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> new file mode 100644
> index 000000000000..e293df9442cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7923.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7923 and similars with 4 and 8 Channel ADCs.
> +
> +maintainers:
> +  - Michael Hennerich <michael.hennerich@xxxxxxxxxx>"

Some left over quotes at the end of each line..

> +  - Patrick Vasseur <patrick.vasseur@xxxxxx>"
> +
> +description: |
> +  Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> +   AD7918, AD7928 8 Channels ADCs.
> +
> +  Specifications about the part can be found at:
> +    https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> +    https://www.analog.com/media/en/technical-documentation/data-sheets/AD7904_7914_7924.pdf
> +    https://www.analog.com/media/en/technical-documentation/data-sheets/AD7908_7918_7928.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,ad7904
> +      - adi,ad7914
> +      - adi,ad7923
> +      - adi,ad7924
> +      - adi,ad7908
> +      - adi,ad7918
> +      - adi,ad7928
> +
> +  reg:
> +    maxItems: 1
> +
> +  refin-supply:
> +    description: |
> +      The regulator supply for ADC reference voltage.
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ad7928: adc@0 {
> +        compatible = "adi,ad7928";
> +        reg = <0>;
> +        spi-max-frequency = <25000000>;
> +        refin-supply = <&adc_vref>;
> +
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +      };
> +    };