Re: [patch V2 11/17] ARM/arm64: vdso: Use common vdso clock mode storage

[Vincenzo Frascino]

Hi Marek,

On 21/02/2020 11:56, Marek Szyprowski wrote:
> Hi Thomas,
> 
> On 07.02.2020 13:38, Thomas Gleixner wrote:
>> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>
>> Convert ARM/ARM64 to the generic VDSO clock mode storage. This needs to
>> happen in one go as they share the clocksource driver.
>>
>> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
>> Tested-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> 
> This patch landed in today's linux-next (next-20200221) as commit 
> 5e3c6a312a09. It breaks ARM 32bit build without VDSO enabled in .config:
> 
> $ make ARCH=arm multi_v7_defconfig
> 
> $ ./scripts/config -e ARM_LPAE -e VIRTUALIZATION -e KVM -d VDSO
> 
> $ make ARCH=arm olddefconfig
> 
> $ make
> 
> ...
> 
> drivers/clocksource/arm_arch_timer.c:73:44: error: 
> âVDSO_CLOCKMODE_ARCHTIMERâ undeclared here (not in a function)
>  Âstatic enum vdso_clock_mode vdso_default = VDSO_CLOCKMODE_ARCHTIMER;
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ^
> scripts/Makefile.build:267: recipe for target 
> 'drivers/clocksource/arm_arch_timer.o' failed
> make[2]: *** [drivers/clocksource/arm_arch_timer.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> scripts/Makefile.build:505: recipe for target 'drivers/clocksource' failed
> make[1]: *** [drivers/clocksource] Error 2
> make[1]: *** Waiting for unfinished jobs....
> Makefile:1683: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
> 
>> ...
> 
> Best regards
> 

I think I have a fix for your problem, could you please try it [1]?

[1]  https://lore.kernel.org/lkml/20200221130355.21373-1-vincenzo.frascino@xxxxxxx/
-- 
Regards,
Vincenzo

Attachment: pEpkey.asc
Description: application/pgp-keys