Re: [PATCH 2/3] samples/hw_breakpoint: Drop use of kallsyms_lookup_name()

[Will Deacon]

On Fri, Feb 21, 2020 at 03:13:54PM +0100, Christoph Hellwig wrote:
> On Fri, Feb 21, 2020 at 11:44:03AM +0000, Will Deacon wrote:
> > -static char ksym_name[KSYM_NAME_LEN] = "pid_max";
> > +static char ksym_name[KSYM_NAME_LEN] = "jiffies";
> 
> Is jiffies actually an exported symbol on all configfs?  I thought
> there was some weird aliasing going on with jiffies64.

There is some weird aliasing with jiffies_64, but kernel/time/jiffies.c
has an unconditional:

EXPORT_SYMBOL(jiffies);

so I think we're ok.

> Except for the symbol choice this looks fine, though:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Brill, cheers.

Will