Re: [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT 82P33 SMU.

From: Richard Cochran
Date: Fri Feb 21 2020 - 12:19:17 EST


On Fri, Feb 21, 2020 at 03:51:28AM -0800, Richard Cochran wrote:
> > + channel->ptp_clock = ptp_clock_register(&channel->caps, NULL);
> > +
> > + if (IS_ERR(channel->ptp_clock)) {
> > + err = PTR_ERR(channel->ptp_clock);
> > + channel->ptp_clock = NULL;
> > + return err;
> > + }
>
> The function, ptp_clock_register(), can also return NULL. Please
> handle that case as well.
>
> > +
> > + if (!channel->ptp_clock)
> > + return -ENOTSUPP;

Duh! Never mind that last comment!

Thanks,
Richard