Re: [PATCH v7 22/24] iomap: Convert from readpages to readahead

From: Matthew Wilcox
Date: Fri Feb 21 2020 - 20:09:58 EST

On Fri, Feb 21, 2020 at 05:03:53PM -0800, Darrick J. Wong wrote:
> On Wed, Feb 19, 2020 at 01:01:01PM -0800, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
> >
> > Use the new readahead operation in iomap. Convert XFS and ZoneFS to
> > use it.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Ok... so from what I saw in the mm patches, this series changes
> readahead to shove the locked pages into the page cache before calling
> the filesystem's ->readahead function. Therefore, this (and the
> previous patch) are more or less just getting rid of all the iomap
> machinery to put pages in the cache and instead pulling them out of the
> mapping prior to submitting a read bio?


> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>