Re: [PATCH] powerpc/watchpoint: Don't call dar_within_range() for Book3S

[Ravi Bangoria]

On 2/22/20 4:56 PM, Christophe Leroy wrote:
> On 02/22/2020 08:20 AM, Ravi Bangoria wrote:
> > DAR is set to the first byte of overlap between actual access and
> > watched range at DSI on Book3S processor. But actual access range
> > might or might not be within user asked range. So for Book3S, it
> > must not call dar_within_range().
> >
> > This revert portion of commit 39413ae00967 ("powerpc/hw_breakpoints:
> > Rewrite 8xx breakpoints to allow any address range size.").
> >
> > Before patch:
> > ÂÂ # ./tools/testing/selftests/powerpc/ptrace/perf-hwbreak
> > ÂÂ ...
> > ÂÂ TESTED: No overlap
> > ÂÂ FAILED: Partial overlap: 0 != 2
> > ÂÂ TESTED: Partial overlap
> > ÂÂ TESTED: No overlap
> > ÂÂ FAILED: Full overlap: 0 != 2
> > ÂÂ failure: perf_hwbreak
> >
> > After patch:
> > ÂÂ TESTED: No overlap
> > ÂÂ TESTED: Partial overlap
> > ÂÂ TESTED: Partial overlap
> > ÂÂ TESTED: No overlap
> > ÂÂ TESTED: Full overlap
> > ÂÂ success: perf_hwbreak
> >
> > Fixes: 39413ae00967 ("powerpc/hw_breakpoints: Rewrite 8xx breakpoints to allow any address range size.")
>
> Oh, this seems to have been introduced by 27985b2a640e ("powerpc/watchpoint: Don't ignore extraneous exceptions blindly").
>
> I must have lost it through a rebase as we were doing our series approximately at the same time, sorry for that.
>
> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx>

No worries. Thanks for the review :)

Ravi