Re: [PATCH 4.19 188/191] cifs: log warning message (once) if out of disk space

From: Sasha Levin
Date: Sat Feb 22 2020 - 11:22:12 EST

On Sat, Feb 22, 2020 at 01:59:31PM +0100, Pavel Machek wrote:
On Fri 2020-02-21 08:42:41, Greg Kroah-Hartman wrote:
From: Steve French <stfrench@xxxxxxxxxxxxx>

[ Upstream commit d6fd41905ec577851734623fb905b1763801f5ef ]

We ran into a confusing problem where an application wasn't checking
return code on close and so user didn't realize that the application
ran out of disk space. log a warning message (once) in these
cases. For example:

[ 8407.391909] Out of space writing to \\oleg-server\small-share

Out of space can happen on any filesystem, and yes, it can be
confusing. But why is cifs so special that we warn here (and not

cifs isn't special, we tend to take this type of patches that address
usability issues. Here's an example of a similar patch for btrfs from
the previous release (3 days ago):

elsewhere) and why was this marked for stable?

Reading the patch description, it describes a bug that happened because
of lacking kernel feedback.