Re: [PATCH] pinctrl: qcom: sc8180x: gracefully handle missing IO memory resource

From: Linus Walleij
Date: Tue May 16 2023 - 09:27:00 EST


On Sat, May 13, 2023 at 1:35 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:

> If device was probed with incorrect DT or ACPI tables, the IO memory
> resource would be missing and driver would derefernce NULL pointer in
> sc8180x_pinctrl_add_tile_resources(). Add simplep check if IO memory
> resource was provided to silence Smatch warning:
>
> drivers/pinctrl/qcom/pinctrl-sc8180x.c:1664 sc8180x_pinctrl_add_tile_resources() error: potentially dereferencing uninitialized 'mres'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Patch applied as non-urgent fix.

Yours,
Linus Walleij