Re: [PATCH] usb: hide unused usbfs_notify_suspend/resume functions

[Alan Stern]

On Tue, May 16, 2023 at 10:17:42PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> The declaration is in an #ifdef, which causes warnings when building
> with 'make W=1' and without CONFIG_PM:
> 
> drivers/usb/core/devio.c:742:6: error: no previous prototype for 'usbfs_notify_suspend'
> drivers/usb/core/devio.c:747:6: error: no previous prototype for 'usbfs_notify_resume'
> 
> Use the same #ifdef check around the function definitions to avoid
> the warnings and slightly shrink the USB core.
> 
> Fixes: 7794f486ed0b ("usbfs: Add ioctls for runtime power management")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

>  drivers/usb/core/devio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index e501a03d6c70..1622ad35428d 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -738,6 +738,7 @@ static int driver_resume(struct usb_interface *intf)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_PM
>  /* The following routines apply to the entire device, not interfaces */
>  void usbfs_notify_suspend(struct usb_device *udev)
>  {
> @@ -756,6 +757,7 @@ void usbfs_notify_resume(struct usb_device *udev)
>  	}
>  	mutex_unlock(&usbfs_mutex);
>  }
> +#endif
>  
>  struct usb_driver usbfs_driver = {
>  	.name =		"usbfs",
> -- 
> 2.39.2
>