Re: [PATCH v4 28/41] rtc: add HAS_IOPORT dependencies

From: Niklas Schnelle
Date: Wed May 17 2023 - 04:16:40 EST


On Tue, 2023-05-16 at 16:49 +0100, Maciej W. Rozycki wrote:
> On Tue, 16 May 2023, Niklas Schnelle wrote:
>
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 753872408615..9ae082b14c44 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -956,6 +956,7 @@ comment "Platform RTC drivers"
> > config RTC_DRV_CMOS
> > tristate "PC-style 'CMOS'"
> > depends on X86 || ARM || PPC || MIPS || SPARC64
> > + depends on HAS_IOPORT
>
> NAK, this hasn't addressed my input for v2. Arnd also followed up with
> similar observations with v3.
>
> Maciej

Ah sorry about that, I had marked the mail as TODO but going over it
missed the proposed fix. Changed this to "depends on HAS_IOPORT ||
ARCH_DECSTATION" for v5.