Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback

[Sasha Levin]

On Mon, May 01, 2023 at 05:26:32PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> > [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ]
> >
> > Exiting early in remove without releasing all acquired resources yields
> > leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
> > .remove() returns, even if the return code was negative.
> >
> > While blocking_notifier_chain_unregister() won't fail and so the
> > change is somewhat cosmetic, platform driver's .remove callbacks are
> > about to be converted to return void. To prepare that, keep the error
> > message but don't return early.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> While I'm positive this change doesn't break anything, it also doesn't
> fix anything and is only cosmetic (+ preparing a later change).
>
> Unless you need it as a dependency I'd say, don't backport it for
> stable.

Ack, dropped. Thanks!

--
Thanks,
Sasha