Re: [PATCH AUTOSEL 6.3 08/59] bpf, mips: Implement DADDI workarounds for JIT

From: Sasha Levin
Date: Thu May 18 2023 - 13:03:09 EST


On Fri, May 05, 2023 at 01:04:14PM +0100, Jiaxun Yang wrote:


2023年5月4日 20:40,Sasha Levin <sashal@xxxxxxxxxx> 写道:

From: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

[ Upstream commit bbefef2f07080cd502a93cb1c529e1c8a6c4ac8e ]

For DADDI errata we just workaround by disable immediate operation
for BPF_ADD / BPF_SUB to avoid generation of DADDIU.

All other use cases in JIT won't cause overflow thus they are all safe.

Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
Acked-by: Johan Almbladh <johan.almbladh@xxxxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/bpf/20230228113305.83751-2-jiaxun.yang@xxxxxxxxxxx
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Hi Sasha,

I think this patch should count as a functional improvement instead of regression fix.

Please drop it from stable queue.

Dropped, thanks!

--
Thanks,
Sasha