Re: [PATCH v1] meson saradc: fix clock divider mask length

From: Andy Shevchenko
Date: Sun May 21 2023 - 04:57:23 EST


On Sat, May 20, 2023 at 6:30 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Wed, 17 May 2023 16:47:59 +0000
> Старк Георгий Николаевич <GNStark@xxxxxxxxxxxxxx> wrote:
> > On 5/16/23 22:08, Martin Blumenstingl wrote:

...

> > I've checked datasheets of all chips listed in meson_sar_adc_of_match array in meson_saradc.c and everywhere this field is 6 bits long. According to driver code and existing dts files this patch affects all supported chips except meson8.
>
> On that note, do we want to add any clarifying text on the scope to the
> commit message?

We should, I think, but according to Martin's message, as I may
interpret it, the datasheet may also be wrong and some experiments on
a real hardware should prepend any change in the code.


--
With Best Regards,
Andy Shevchenko