Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid

From: John Garry
Date: Mon May 22 2023 - 05:56:12 EST

On 19/05/2023 18:39, Bart Van Assche wrote:

Hi Bart,

      *args->resid = scmd->resid_len;
-    if (args->sense)
-        memcpy(args->sense, scmd->sense_buffer, SCSI_SENSE_BUFFERSIZE);
+    if (args->sense) {
+        *args->sense = scmd->sense_buffer;
+        scmd->sense_buffer = NULL;

I think that you will agree that this is not a good pattern to follow. We cannot have SCSI core allocating the sense buffer but a driver freeing it.

Thanks,
John