Re: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset

[Martin Blumenstingl]

On Mon, May 22, 2023 at 3:49 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> > Sent: Friday, May 19, 2023 12:18 AM
> > To: linux-wireless@xxxxxxxxxxxxxxx
> > Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx; kvalo@xxxxxxxxxx;
> > tony0620emma@xxxxxxxxx; Peter Robinson <pbrobinson@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>;
> > jernej.skrabec@xxxxxxxxx; Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> > Subject: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset
> >
> > Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
> > as the existing RTL8723D chipset code.
> >
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
> I'm so surprised that this small patchset can support an new chip. Nice job. :-)
Please also take it as feedback/learning for yourself and to your team
at Realtek:
In my opinion the rtw88 driver is a good piece of software and it
shows why it is the first choice that Jernej and I had in mind when
thinking about future RTL8723BS support.

> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Thank you!


Best regards,
Martin