Re: [PATCH] perf symbol: Add LoongArch case in get_plt_sizes()

From: Leo Yan
Date: Tue May 23 2023 - 03:31:20 EST


On Tue, May 23, 2023 at 09:47:19AM +0800, Huacai Chen wrote:

[...]

> > > I'm very sorry that this patch breaks cross-build. We need some
> > > additional modification.
> > >
> > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> > > index 5d409c26a22e..b3dbf6ca99a7 100644
> > > --- a/tools/perf/util/symbol-elf.c
> > > +++ b/tools/perf/util/symbol-elf.c
> > > @@ -35,6 +35,10 @@
> > > #define EM_AARCH64 183 /* ARM 64 bit */
> > > #endif
> > >
> > > +#ifndef EM_LOONGARCH
> > > +#define EM_LOONGARCH 258
> > > +#endif
> > > +

I confirmed that we must apply this change, otherwise, it will
introduce perf building failure on Ubuntu 22.04 (jammy) with my Arm64
machine.

Sorry I didn't detect the building failure when reviewed this patch!

Thanks,
Leo