Re: [PATCH] perf symbol: Add LoongArch case in get_plt_sizes()

[Tiezhu Yang]

On 05/23/2023 03:30 PM, Leo Yan wrote:
> On Tue, May 23, 2023 at 09:47:19AM +0800, Huacai Chen wrote:
>
> [...]
>
> > > > I'm very sorry that this patch breaks cross-build. We need some
> > > > additional modification.
> > > >
> > > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> > > > index 5d409c26a22e..b3dbf6ca99a7 100644
> > > > --- a/tools/perf/util/symbol-elf.c
> > > > +++ b/tools/perf/util/symbol-elf.c
> > > > @@ -35,6 +35,10 @@
> > > >  #define EM_AARCH64     183  /* ARM 64 bit */
> > > >  #endif
> > > >
> > > > +#ifndef EM_LOONGARCH
> > > > +#define EM_LOONGARCH   258
> > > > +#endif
> > > > +
>
> I confirmed that we must apply this change, otherwise, it will
> introduce perf building failure on Ubuntu 22.04 (jammy) with my Arm64
> machine.
>
> Sorry I didn't detect the building failure when reviewed this patch!

Sorry for that, EM_LOONGARCH was added in binutils in 2020 [1],
and then it was added in glibc in 2022 [2], so it may be not
exist on some systems.

For now, I do not find the related commit of this patch in any
branch of acme/linux.git, so it is better to send v2 to avoid
the build error, I will do it as soon as possible.

[1] 
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=4cf2ad720078
[2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=2d83247d90c9

Thanks,
Tiezhu