Re: [PATCH v2 2/7] ASoC: dt-bindings: mediatek,mt8188-mt6359: remove ADDA_BE from link-name

[Trevor Wu (吳文良)]

On Tue, 2023-05-23 at 18:26 +0200, Alexandre Mergnat wrote:
> On 23/05/2023 04:19, Trevor Wu wrote:
> > ADDA_BE is used to connect to mt6359. For machine mt8188-mt6359,
> > codec
> > for ADDA_BE must be mt6359 which are configured on the machine
> > driver.
> > Besides, ADDA_BE is divided into two dais, UL_SRC_BE and DL_SRC_BE.
> > As a result, remove ADDA_BE from items of link-name.
> > 
> > Signed-off-by: Trevor Wu<trevor.wu@xxxxxxxxxxxx>
> 
> I don't understand how "DL_SRC_BE" and "UL_SRC_BE" links are done.
> Why these dais don't replace "ADDA_BE" in this binding ?
> 
> Regards,
> Alexandre
> 

Hi Alexandre,

Because the sound card is mt8188-mt6359, the codec for these two links
must be mt6359. Thus, I specifiy the codec in machine driver directly.
If the codec is changed, there will be a new sound card and binding
file. In conclusion, the codec won't be updated via dts, and that's why
I don't just replace ADDA_BE in this binding.

Do you suggest me add some information in the commit message?

Thanks,
Trevor