Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()
From: Christoph Hellwig
Date: Thu Feb 01 2024 - 00:30:12 EST
On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote:
> Prototype for __symbol_get_gpl() was introduced in the initial git
> commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that.
>
> In commit 9011e49d54dc ("modules: only allow symbol_get of
> EXPORT_SYMBOL_GPL modules") Christoph Hellwig switched __symbol_get()
> to process GPL symbols only, most likely this is what
> __symbol_get_gpl() was designed to do.
>
> We might either define __symbol_get_gpl() as __symbol_get() or remove
> it completely as suggested by Mauro Carvalho Chehab.
Just remove it, there is no need to keep unused funtionality around.
Btw, where did the discussion start? I hope you're not trying to
add new symbol_get users?