RE: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100

From: JiaJie Ho
Date: Thu Feb 01 2024 - 02:34:07 EST


> On Thu, Feb 01, 2024 at 03:01:59AM +0000, JiaJie Ho wrote:
> >
> > I am using ifdef so unused codes wouldn't be compiled into the driver for
> unsupported variant.
> > Is the compiled driver size a concern for such cases?
>
> The compiler should be eliminating unused code for you. Is this not the case?

Currently, the object files defining new algo register/unregister functions weren't included in Makefile for unsupported device.
Compiler will still check for these definitions if IS_ENABLED is used instead of ifdef causing build errors.

Best regards,
Jia Jie