Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode

From: Francesco Dolcini
Date: Thu Feb 01 2024 - 03:52:30 EST


On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote:
> > From: Francesco Dolcini <francesco@xxxxxxxxxx>
> > Add #include <linux/bits.h> given you are using BITS_PER_BYTE
> >
> I found that <linux/property.h> has been included in spi-imx.c driver.
> And <linux/bits.h> has been included in <linux/property.h>.
> So I didn't add the "#include <linux/bits.h>" on purpose.

I think you should be explicit and include this header.
Code get refactored all the time and you can prevent issues this way.

Francesco