Re: [PATCH v7 03/16] virt: sev-guest: Add SNP guest request structure

[Borislav Petkov]

On Wed, Jan 31, 2024 at 07:28:05PM +0530, Nikunj A. Dadhania wrote:
> Changed to "req" for all the guest request throughout the file. Other "req" 
> usage are renamed appropriately.

Yes, better from what I can tell.

However, I can't apply this patch in order to have a better look, it is
mangled. Next time, before you send a patch this way, send it yourself
first and try applying it.

If it doesn't work, throw away your mailer and use a proper one:

Documentation/process/email-clients.rst

> Subject: [PATCH] virt: sev-guest: Add SNP guest request structure
> 
> Add a snp_guest_req structure to simplify the function arguments. The
> structure will be used to call the SNP Guest message request API
> instead of passing a long list of parameters. Use "req" as variable name
> for guest req throughout the file and rename other variables appropriately.
> 
> Update snp_issue_guest_request() prototype to include the new guest request
> structure and move the prototype to sev_guest.h.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@xxxxxxx>
> Tested-by: Peter Gonda <pgonda@xxxxxxxxxx>

Tested-by: tags must be dropped if you change a patch in a non-trivial
way. And this change is not that trivial I'd say.

> ---
>  .../x86/include/asm}/sev-guest.h              |  18 ++
>  arch/x86/include/asm/sev.h                    |   8 -
>  arch/x86/kernel/sev.c                         |  16 +-
>  drivers/virt/coco/sev-guest/sev-guest.c       | 195 ++++++++++--------
>  4 files changed, 135 insertions(+), 102 deletions(-)
>  rename {drivers/virt/coco/sev-guest => arch/x86/include/asm}/sev-guest.h (78%)

I didn't notice this before: why am I getting a sev-guest.h header in
arch/x86/?

Lemme quote again the file paths we agreed upon:

https://lore.kernel.org/all/Yg5nh1RknPRwIrb8@xxxxxxx/

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette