Re: [PATCH v4 6/6] arm64: dts: qcom: aim300: add AIM300 AIoT

From: Tengfei Fan
Date: Thu Feb 01 2024 - 06:51:06 EST




On 1/30/2024 3:25 PM, Tengfei Fan wrote:


On 1/29/2024 4:18 PM, Tengfei Fan wrote:


On 1/29/2024 4:09 PM, Krzysztof Kozlowski wrote:
On 19/01/2024 11:06, Tengfei Fan wrote:
Add AIM300 AIoT board DTS support, including usb, serial, PCIe, mpss,
adsp, cdsp and sound card functions support.


...

+
+    sound {
+        compatible = "qcom,sm8550-sndcard", "qcom,sm8450-sndcard";
+        model = "AIM300-AIOT";
+        audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+                "SpkrRight IN", "WSA_SPK2 OUT",
+                "IN1_HPHL", "HPHL_OUT",
+                "IN2_HPHR", "HPHR_OUT",
+                "AMIC2", "MIC BIAS2",
+                "VA DMIC0", "MIC BIAS1",
+                "VA DMIC1", "MIC BIAS1",
+                "VA DMIC2", "MIC BIAS3",
+                "TX DMIC0", "MIC BIAS1",
+                "TX DMIC1", "MIC BIAS2",
+                "TX DMIC2", "MIC BIAS3",
+                "TX SWR_ADC1", "ADC2_OUTPUT";

This should be probably TX SWR_INPUT1.

Best regards,
Krzysztof


I will double check this with related team and I will update this.


I will apply "TX SWR_INPUT1" on audio-routing node in the next patch series.


This patch series has been sent for nearly two weeks. do you think it is better to modify the patch series acording to the current comments and submit a new patch series, or continue to wait for your review comments on the current path series?

--
Thx and BRs,
Tengfei Fan