Re: [PATCH] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled

From: Andy Shevchenko
Date: Thu Feb 01 2024 - 08:35:31 EST


On Thu, Feb 01, 2024 at 02:19:38PM +0200, Arturas Moskvinas wrote:
> On Thu, Feb 1, 2024 at 2:03 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> wrote:

..

> > > + /* We must check all of the inputs with enabled interrupts
> > > + * on the chip, otherwise we may not notice a change
> > > + * on >=2 pins.
> >
> > Missing space after =. But better to spell in proper English, i.e.
> > "...great than or equal to 2 pins."
> >
> + /*
> + * We must check all of the inputs with enabled interrupts
> + * on the chip, otherwise we may not notice a change
> + * on more than one pin.
>
> Does this sound better?

LGTM, thanks.

--
With Best Regards,
Andy Shevchenko