Re: [PATCH net v3] net: stmmac: xgmac: fix handling of DPP safety error for DMA channels

From: Simon Horman
Date: Thu Feb 01 2024 - 08:44:21 EST


On Wed, Jan 31, 2024 at 10:08:28AM +0800, Furong Xu wrote:
> Commit 56e58d6c8a56 ("net: stmmac: Implement Safety Features in
> XGMAC core") checks and reports safety errors, but leaves the
> Data Path Parity Errors for each channel in DMA unhandled at all, lead to
> a storm of interrupt.
> Fix it by checking and clearing the DMA_DPP_Interrupt_Status register.
>
> Fixes: 56e58d6c8a56 ("net: stmmac: Implement Safety Features in XGMAC core")
> Signed-off-by: Furong Xu <0x1207@xxxxxxxxx>
> ---
> Changes in v3:
> - code style fix, thanks Paolo Abeni
>
> Changes in v2:
> - explicit enable Data Path Parity Protection
> - add new counters to stmmac_safety_stats
> - add detailed log

Thanks for the updates.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>