Re: [PATCH 03/15] tick: Remove useless oneshot ifdeffery

[Anna-Maria Behnsen]

Frederic Weisbecker <frederic@xxxxxxxxxx> writes:

> Le Thu, Feb 01, 2024 at 10:40:10AM +0100, Anna-Maria Behnsen a écrit :
>> Frederic Weisbecker <frederic@xxxxxxxxxx> writes:
>> 
>> > tick-sched.c is only built when CONFIG_TICK_ONESHOT=y, which is selected
>> > only if CONFIG_NO_HZ_COMMON=y or CONFIG_HIGH_RES_TIMERS=y. Therefore
>> > the related ifdeferry in this file is needless and can be removed.
>> >
>> > Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> > Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
>> 
>> It's a nitpick, but shouldn't the ordering of sob and reviewed-by be the
>> other way round?
>
> I've seen it both ways here and there, I'm not sure if there is a strict rule
> for it...
>

As it is for the tip maintainers, they have some rules - I don't know
how strictly they are used :)

  Documentation/process/maintainer-tip.rst