Re: [patch v5 07/19] x86/cpu: Use common topology code for Intel

[Borislav Petkov]

On Tue, Jan 23, 2024 at 01:53:40PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> Intel CPUs use either topology leaf 0xb/0x1f evaluation or the legacy
> SMP/HT evaluation based on CPUID leaf 0x1/0x4.
> 
> Move it over to the consolidated topology code and remove the random
> topology hacks which are sprinkled into the Intel and the common code.
> 
> No functional change intended.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Tested-by: Juergen Gross <jgross@xxxxxxxx>
> Tested-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
> Tested-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
> 
> 
> ---
>  arch/x86/kernel/cpu/common.c          |   65 ----------------------------------
>  arch/x86/kernel/cpu/cpu.h             |    4 --
>  arch/x86/kernel/cpu/intel.c           |   25 -------------
>  arch/x86/kernel/cpu/topology_common.c |    5 ++
>  4 files changed, 4 insertions(+), 95 deletions(-)

Right:

arch/x86/kernel/cpu/topology.c:62:5: warning: no previous prototype for ‘detect_extended_topology_early’ [-Wmissing-prototypes]
   62 | int detect_extended_topology_early(struct cpuinfo_x86 *c)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That one is already unused after this one - might zap it here.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette