Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add wol-arp-packet property

[Karumanchi, Vineeth]

Hi Andrew,

On 2/1/2024 6:42 PM, Andrew Lunn wrote:
> On Thu, Feb 01, 2024 at 12:11:15PM +0530, Vineeth Karumanchi wrote:
<...>
> > The earlier implementation of WOL (magic-packet) was using DT property.
> > We added one more packet type using DT property to be in-line with the
> > earlier implementation.
>
> I can understand that. It also suggests we did a bad job reviewing
> that patch, and should of rejected it. But it was added a long time
> ago, and we were less strict back then.
>
> > However, I echo with you that this feature should be in driver (CAPS).
> > We will re-work the implementation with the below flow:
> >
> > - Add MACB_CAPS_WOL capability to the supported platforms
> > - Advertise supported WOL packet types based on the CAPS in ethtool.
> > - Users can set packet type using ethtool.
>
> Yes, this sounds good. Maybe add to that, mark magic-packet
> deprecated, and a comment that ethtool should be used instead.

OK. We will implement above functionality and send V2.

Thanks
--
🙏 vineeth
> Thanks
> 	Andrew