Re: [PATCH v2 1/3] crypto: padlock-sha: Matches CPU with Family with 6 explicitly

From: Dave Hansen
Date: Thu Feb 01 2024 - 11:42:32 EST


On 1/31/24 18:37, Tony W Wang-oc wrote:
> Sorry. It should be said that there are non-CENTAUR or non-family-6 CPUs
> that set X86_FEATURE_PHE,
>
> and also set the new X86_FEATURE_PHE2.  For these CPUs, we expect to use
> a new driver that supports
>
> both X86_FEATURE_PHE and X86_FEATURE_PHE2.
>
> So we make the driver padlock-sha to matches CENTAUR Family-6 CPU
> explicitly.

Could you please take a look at how this is done for the existing crypto
algorithms? This doesn't seem horribly new. We have AVX-512-based
algorithms that somehow work on systems that also have AVX and AVX2
support. Yet, there are no other vendor or family matches in the
x86_cpu_id arrays for them. Why?