Re: [PATCH 5/6] eventfs: Add WARN_ON_ONCE() to checks in eventfs_root_lookup()

[Steven Rostedt]

On Thu, 01 Feb 2024 10:34:51 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> --- a/fs/tracefs/event_inode.c
> +++ b/fs/tracefs/event_inode.c
> @@ -483,7 +483,7 @@ static struct dentry *eventfs_root_lookup(struct inode *dir,
>  	struct dentry *result = NULL;
>  
>  	ti = get_tracefs(dir);
> -	if (!(ti->flags & TRACEFS_EVENT_INODE))
> +	if (WARN_ON_ONCE!(ti->flags & TRACEFS_EVENT_INODE)))

I added this patch at the end but never tested it :-p

I then did a rebase to move it ahead of patch 6, which was tested.

Will resend this patch.

-- Steve


>  		return ERR_PTR(-EIO);
>  
>  	mutex_lock(&eventfs_mutex);