Re: [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast()

From: Sohil Mehta
Date: Thu Feb 01 2024 - 17:24:56 EST


On 1/23/2024 5:10 AM, Thomas Gleixner wrote:

> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c

> @@ -1499,15 +1498,14 @@ static void __init setup_ioapic_ids_from
> */
> if (apic->check_apicid_used(&phys_id_present_map,
> mpc_ioapic_id(ioapic_idx))) {
> - printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
> + pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
> ioapic_idx, mpc_ioapic_id(ioapic_idx));

The second line could be aligned to match the open parenthesis.