Re: [patch v2 25/30] x86/cpu/topology: Use topology logical mapping mechanism

[Sohil Mehta]

On 1/23/2024 5:11 AM, Thomas Gleixner wrote:

> --- a/arch/x86/include/asm/topology.h
> +++ b/arch/x86/include/asm/topology.h
> @@ -172,6 +172,13 @@ static inline int topology_get_logical_i
>  #define topology_core_cpumask(cpu)		(per_cpu(cpu_core_map, cpu))
>  #define topology_sibling_cpumask(cpu)		(per_cpu(cpu_sibling_map, cpu))
>  
> +

This additional new line can be avoided.

> +static inline int topology_phys_to_logical_pkg(unsigned int pkg)
> +{
> +	return topology_get_logical_id(pkg << x86_topo_system.dom_shifts[TOPO_PKG_DOMAIN],
> +				       TOPO_PKG_DOMAIN);
> +}
> +