Re: [net-next PATCH v5 9/9] net: phy: qca807x: add support for configurable LED

[Andrew Lunn]

> +
> +			phydev->drv->led_brightness_set = NULL;
> +			phydev->drv->led_blink_set = NULL;
> +			phydev->drv->led_hw_is_supported = NULL;
> +			phydev->drv->led_hw_control_set = NULL;
> +			phydev->drv->led_hw_control_get = NULL;

I don't see how that works. You have multiple PHYs using this
driver. Some might have LEDs, some might have GPOs. But if you modify
the driver structure like this, you prevent all PHYs from having LEDs,
and maybe cause a Opps if a PHY device has already registered its
LEDs?

	Andrew