RE: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.

From: Ratheesh Kannoth
Date: Fri Feb 02 2024 - 02:35:58 EST


>From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
>
> On Thu, 1 Feb 2024 09:35:15 +0000 Ratheesh Kannoth wrote:
> > > The use of bitmap_zalloc()/bitmap_free() looks good to me.
> > > But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I
> > > think
> > > kcalloc() is the way to go.
> > Kcalloc() is a wrapper around kmalloc_array(). Why do you think
> > kcalloc() Is better ?
>
> Are you genuinely asking for an explanation why
> kcalloc() is better than kmalloc_array()?
Yes.

>It's an equivalent to the standard C
> function, calloc().
Thanks.
>
> The reviewers are the most valuable part of this community, we will not take
> frustrating them lightly :|
I learn a lot from review comments provided by this community and do value
them. I am sorry if my "English" sounded harsh.