Re: [PATCH] nfsd: Simplify the allocation of slab caches in nfsd_drc_slab_create

[Benjamin Coddington]

On 1 Feb 2024, at 3:19, Kunwu Chan wrote:

> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> Make the code cleaner and more readable.
>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> ---
>  fs/nfsd/nfscache.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
> index 5c1a4a0aa605..64ce0cc22197 100644
> --- a/fs/nfsd/nfscache.c
> +++ b/fs/nfsd/nfscache.c
> @@ -166,8 +166,7 @@ nfsd_reply_cache_free(struct nfsd_drc_bucket *b, struct nfsd_cacherep *rp,
>
>  int nfsd_drc_slab_create(void)
>  {
> -	drc_slab = kmem_cache_create("nfsd_drc",
> -				sizeof(struct nfsd_cacherep), 0, 0, NULL);
> +	drc_slab = KMEM_CACHE(nfsd_cacherep, 0);
>  	return drc_slab ? 0: -ENOMEM;
>  }
>
> -- 
> 2.39.2

I don't agree that the code is cleaner or more readable like this.  I really
dislike having to parse through the extra "simplification" to see what's
actually being called and sent.

Just my .02 worth.

Ben