Re: [PATCH 1/1] Modify macro NETLBL_CATMAP_MAPTYPE to define a type using typedef

From: Paul Moore
Date: Fri Feb 02 2024 - 10:32:00 EST


On Thu, Feb 1, 2024 at 10:45 PM George Guo <dongtai.guo@xxxxxxxxx> wrote:
>
> From: George Guo <guodongtai@xxxxxxxxxx>
>
> Modify NETLBL_CATMAP_MAPTYPE to netlbl_catmap_map_t, which is more
> readable.
>
> Signed-off-by: George Guo <guodongtai@xxxxxxxxxx>
> ---
> include/net/netlabel.h | 8 ++++----
> net/netlabel/netlabel_kapi.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)

I'm generally not in favor of minor rename patches like this unless
they are part of a larger effort (code churn with little benefit).
I'm not going to block it if the netdev folks want to merge this, but
I can't say I really support it either.

--
paul-moore.com