Re: 回复: 回复: [v2] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Conor Dooley]

On Fri, Feb 02, 2024 at 02:29:16AM +0000, Changhuang Liang wrote:
> 
> Hi, Conor,
> 
> [...]
> > > > > +	imx219_clk: imx219-clock {
> > > > > +		compatible = "fixed-clock";
> > > > > +		clock-output-names = "imx219_clk";
> > > > > +		clock-frequency = <24000000>;
> > > > > +		#clock-cells = <0>;
> > > > > +	};
> > > >
> > > > Why do you need an output name here?
> > >
> > > The output name can be unnecessary.
> > >
> > > > Also, where does this clock come from? Is it an oscillator on the board?
> > > >
> > >
> > > This clock come from imx219, not the VisionFive 2 board.
> > 
> > If the camera is not on the visionfive 2 board, why are you adding this to
> > visionfive-2.dtsi?
> 
> It seems that I need to use dtso. Right?

Yes. FWIW, the same comments as applied for the sound card Walker tried
to add applies here too, unless this ships with the boards:
| I'm not against allowing in-tree overlays for hats/capes/daughter-boards
| that come bundled with a board, but accepting ones for a hat that
| someone decided to use theoretically has no limit! The "someone" in this
| case might be a StarFive developer, but it could be any random one of
| your customers next!
https://lore.kernel.org/linux-riscv/20230510-riveter-ridden-3f056251e623@spud/

I figure this is a similar case as that?

Attachment: signature.asc
Description: PGP signature