Re: [PATCH 2/2] media: media-devnode: make media_bus_type const

From: Laurent Pinchart
Date: Sun Feb 04 2024 - 03:47:27 EST


Hi Ricardo,

Thank you for the patch.

On Sat, Feb 03, 2024 at 12:31:27PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the media_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ricardo B. Marliere <ricardo@xxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> drivers/media/mc/mc-devnode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c
> index 680fbb3a9340..90646805bd81 100644
> --- a/drivers/media/mc/mc-devnode.c
> +++ b/drivers/media/mc/mc-devnode.c
> @@ -63,7 +63,7 @@ static void media_devnode_release(struct device *cd)
> pr_debug("%s: Media Devnode Deallocated\n", __func__);
> }
>
> -static struct bus_type media_bus_type = {
> +static const struct bus_type media_bus_type = {
> .name = MEDIA_NAME,
> };
>
>

--
Regards,

Laurent Pinchart