Re: Re: Re: [lvc-project] [PATCH] i2c: Fix NULL pointer dereference in npcm_i2c_reg_slave

From: Fedor Pchelkin
Date: Sun Feb 04 2024 - 03:54:51 EST


On 24/02/03 09:44PM, Wolfram Sang wrote:
>
> > If I'm not missing something, npcm_i2c_reg_slave() is called via a
> > function pointer ->reg_slave here [1]. And seems `client` can't be NULL
> > there. Other drivers implementing ->reg_slave function don't check its
> > argument.
>
> Correct, we trust ourselves here.
>
> > Maybe we should just drop `if (!bus->slave)` check?
>
> Yes.
>

Okay, thanks for confirmation.

Rand, would you like to prepare the patch, please?